Closed Bug 445257 Opened 16 years ago Closed 16 years ago

TM: Make sure we don't record across calls that copy argv (or track this copying).

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: gal, Assigned: shaver)

Details

 
A simple trace abort would be fine. But this should be fixed before we land and I don't know how to do it. Assigning it randomly to someone who I think knows how to fix it.
Assignee: general → shaver
I actually fixed this but did not update the comment. From TraceRecorder::interpretedFunctionCall:

    // TODO: make sure args are not copied, or track the copying via the tracker
    if (argc < fun->nargs &&
        jsuword(fp->regs->sp + (fun->nargs - argc)) > cx->stackPool.current->limit) {
        ABORT_TRACE("can't trace calls with too few args requiring argv move");
    }   

Fixing the comment now.

/be
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.