445343 - adding imap saved search creates unneeded .sbd

Status: RESOLVED FIXED

(MailNews Core :: Search, defect)

Description

[David :Bienvenu]

When we create an imap saved search, it creates a .sbd folder for that saved search - I think it really means to be creating a .sbd folder for the parent folder.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

I think this is what the code meant to do - create a .sbd folder for the parent folder.

I'm still working on some other isses having to do with escaping folder names. I want to make sure everything is fixed before getting reviews, in case the patches are dependent on each other.

Comment 2

[David :Bienvenu]

Comment on attachment 329693 [details] [diff] [review]
proposed fix 

turned out the %20 names was unrelated to this issue, so this fix should be sufficient for this issue.

Comment 3

[[e-mail]]

Comment on attachment 329693 [details] [diff] [review]
proposed fix 

>+  PRBool isServer;
>+  rv = GetIsServer(&isServer);
>+  NS_ENSURE_SUCCESS(rv, rv);
>+
>+  if (!isServer)
>+  {
>+  }
I don't think this is necessary - the code checks whether the directory name exists with and without a .sbd before creating it with a .sbd, and (at least in my tests) the server folder is always created when the account is created.

It's good to be getting rid of that unsafe-looking static cast :-)

Comment 4

[David :Bienvenu]

I think you're right - I've [gladly] gotten rid of the isServer check locally.