445596 - mochitest failures due to leaks should TinderboxPrint: something

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

When mochitests fail due to leaks, they should TinderboxPrint: something to indicate that they failed due to leaks.  This makes it clear that a reason for the orange is leaks without having to view the log.

This is particularly important when there are multiple failures happening at the same time (like right now), and nobody would notice that leaks have started until the test failure that's also causing orange is fixed.

Comment 1

[(not currently active) Ted Mielczarek]

We could very easily do this in runtests.py, as long as you don't mind that the leak output would wind up above the summary numbers, since those are generated by buildbot after the tests are run, so you'd see something like:
LEAKED
mochitest:10000/0/100

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Sounds a lot better than nothing (although not perfect).  (How hard would it be to say "mochitest: LEAKED"?)

Comment 3

[(not currently active) Ted Mielczarek]

This is definitely hurting us, bug 446044 for example.

Comment 4

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Fixing this would help clear out "intermittent unittest weirdness".

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> This is definitely hurting us, bug 446044 for example.

I bet it would help bug 448125 too.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)

It looks like you filed this again as bug 468577 :-/
R.Fixed, by it.

(Not duplicating, per dependent bugs and CC list here.)