Closed
Bug 445745
Opened 16 years ago
Closed 16 years ago
Building without MATHML fails after landing 436083
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.1a1
People
(Reporter: romaxa, Assigned: romaxa)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.53 KB,
patch
|
bholley
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
#ifdef MOZ_MATHML ........... GK_ATOM(matrixrow_, "matrixrow") +GK_ATOM(maximum_scale, "maximum-scale") nsContentUtils.cpp:4262: error: `maximum_scale' is not a member of `nsGkAtoms'
|
||
Comment 1•16 years ago
|
||
Your patch includes the removal of a bunch of files. Is that intentional?
|
Assignee | |
Comment 2•16 years ago
|
||
I think it would be better to remove them also... but probably in some other bug...
Attachment #330024 -
Attachment is obsolete: true
|
||
Comment 3•16 years ago
|
||
Could you please request review and get this in? This bug breaks the default Thunderbird build, which has MathML disabled.
|
||
Comment 4•16 years ago
|
||
Comment on attachment 330073 [details] [diff] [review] Updated patch Patch is trivial -- bholley, does this look right to you? And sicking, can you SR this so it can be checked in?
Attachment #330073 -
Flags: superreview?(jonas)
Attachment #330073 -
Flags: review?(bholley)
|
||
Comment 5•16 years ago
|
||
Comment on attachment 330073 [details] [diff] [review] Updated patch yep - my bad. I didn't see that that section was inside an ifdef. r=bholley Thanks dholbert.
Attachment #330073 -
Flags: review?(bholley) → review+
|
|
||
Updated•16 years ago
|
Assignee: nobody → romaxa
Attachment #330073 -
Flags: superreview?(jonas) → superreview+
|
|
||
Updated•16 years ago
|
Keywords: checkin-needed
|
|
||
Comment 6•16 years ago
|
||
Pushed as changeset a3449a66f7ad http://hg.mozilla.org/mozilla-central/index.cgi/rev/a3449a66f7ad
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Updated•16 years ago
|
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.1a1
You need to log in
before you can comment on or make changes to this bug.
Description
•