445853 - Multiple tests with the same class names confuse automatic rewriting

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Benjamin Smedberg]

Attachment: Make some tests use namespaces, rev. 1

In at least one of the XPCOMGC rewrites we are using "global" analysis to determine which classes are instantiated. This analysis is being confused by multiple tests that have class types with the same name.

This is easy enough to fix by using namespaces, which I believe are now ancient enough that all our compilers support them. Asking biesi for review since these are mostly in necko.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 330108 [details] [diff] [review]
Make some tests use namespaces, rev. 1

+++ b/netwerk/test/TestProtocols.cpp
+} // namespace
+using namespace TestProtocols;

should probably put an empty line in here

Comment 2

[Benjamin Smedberg]

Pushed to mozilla-central: http://hg.mozilla.org/mozilla-central/index.cgi/rev/6b425f9adc30