446072 - [Editor] Make the content area in the editor much bigger

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Chris Ilias [:cilias]]

The area where the article source is edited in the page editor should be a lot bigger (wider and taller).

Comment 1

[David Tenser [:djst]]

Can you mockup how you want it to look like and attach it here?

Comment 2

[Brian Krausz]

There is a button on the left under "Edit" to make the edit field taller...is this not sufficient?

Comment 3

[Paul Craciunoiu [:paulc]]

I don't think it can be wider, or it would conflict with the format of the page. But I made the default 10 rows taller in textareasize.php. That should help, unless a default is set somewhere else for $defaultRows
20 rows would have been taller than my 800px screen, which I think most people still have.
Comments?

svn r19309 (trunk)
svn r19311 (prod)

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Hrm; I see 21 rows by default on both http://support.mozilla.com/tiki-editpage.php?locale=en-US&page=*Clearing+Location+bar+history and http://support-stage.mozilla.org/tiki-editpage.php?locale=en-US&page=*Clearing+Location+bar+history; what am I missing?

Comment 5

[Chris Ilias [:cilias]]

They look the same to me as well.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening until we know what's going on.  I see the patch, clearly, I'm just scratching my head as to why this isn't evident on support-stage; Smarty cache, perhaps?

Comment 7

[Paul Craciunoiu [:paulc]]

So, since the line is:
$rows = isset($_REQUEST['rows'])? $_REQUEST['rows']: (isset($defaultRows)?$defaultRows: 30);

... maybe $defaultRows is set. If that is so, then it could have been set by an admin. I haven't used tiki wiki to know, but it seems that $defaultRows can be a variable stored in the db.

Comment 8

[Paul Craciunoiu [:paulc]]

Ding! Got it! I set up a local copy of SUMO and logged in as admin.

Nelson: My SUMO db dump shows you were the admin user. Could you log in and change the textarea default size?

The link should be 
/tiki-admin.php?page=textarea

I see these as textfields:
-------
Default number of rows (wiki):  	
Default number of rows (comments): 	
Default number of rows (forum): 	
Default number of rows (forum replies):
-------

If anyone in this bug wants specific sizes or increase in comments or replies, say so please. So far the (wiki) and (forum) should be increased to ~30.

Comment 9

[Paul Craciunoiu [:paulc]]

Done. No code committed, used admin rights to change prefs.

Comment 10

[Chris Ilias [:cilias]]

Re-opening.
This shouldn't be part of 0.7.2. Sorry for not making this clearer earlier. This is about making the content area wider as well as taller, and is part of the editor redesign.
<http://blog.mozilla.com/sumo/2008/11/05/article-editor-mockups/>

Comment 11

[Paul Craciunoiu [:paulc]]

So now it is both taller and wider, right? Why is it reopened?

Comment 12

[Chris Ilias [:cilias]]

AFAICT, it is not wider. If this were to be applied to the current editor, that would constitute getting rid of the "Edit" button to the left of the content area. Again, I'm sorry for not clarifying this earlier. My fault. :-(

Comment 13

[David Tenser [:djst]]

Chris, can you submit a screenshot of how it looks like today and how you want it to look like?

Comment 14

[Chris Ilias [:cilias]]

Attachment: current editor

Comment 15

[Chris Ilias [:cilias]]

Attachment: wider content area

Comment 16

[Paul Craciunoiu [:paulc]]

Sounds good, when would we like to have this?

Comment 17

[David Tenser [:djst]]

Suggest Future since this hasn't been requested by other article editors (that I'm aware of, at least). If there are no lower priority bugs in your todo list, Paul, feel free to submit a patch. :)

Comment 18

[Paul Craciunoiu [:paulc]]

We can get this done when we get to an editor-redesign milestone.

Comment 19

[Marc Laporte]

There is a full screen mode in recent versions of Tiki:
http://doc.tikiwiki.org/Fullscreen

You can swap from normal to fullscreen when in edit mode.

Comment 20

[Chris Ilias [:cilias]]

fixed in kitsune 
https://master.support.mozilla.com/en-US/kb/How%20to%20set%20the%20home%20page/edit