446346 - test_Microformats_count.html can fail sporadically with "Error thrown during test: test_MicroformatsAPI is not defined - got 0, expected 1"

Status: RESOLVED FIXED

(Toolkit Graveyard :: Microformats, defect)

Description

[(not currently active) Ted Mielczarek]

This test failed on qm-win2k3-moz2-01, it looks like the iframe is loading before the script after it gets evaluated. Probably a fix would be to move the script up above the iframe to ensure it's evaluated beforehand. This probably only shows up on VMs because of the timing involved.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: move the script block before the iframe

Here's a simple patch, just moves the script tag up before the iframe. The test succeeds for me with this change, should get rid of that race condition as well.

Comment 2

[(not currently active) Ted Mielczarek]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/37f174b07950

Comment 3

[(not currently active) Ted Mielczarek]

Checked into CVS:
Checking in toolkit/components/microformats/tests/test_Microformats_count.html;
/cvsroot/mozilla/toolkit/components/microformats/tests/test_Microformats_count.h
tml,v  <--  test_Microformats_count.html
new revision: 1.2; previous revision: 1.1
done

Comment 4

[Robert Strong (they/them - no direct email)]

Bug 488233 might be similar