446507 - Can't highlight lines in HG Blame listings

Status: RESOLVED WONTFIX

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Mats Palmgren (inactive)]

Can't highlight lines in HG Blame listings.

Example from old CVS Blame:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/base/nsCSSFrameConstructor.cpp&rev=1.1473&root=/cvsroot&mark=8623-8635#8602

Comment 1

[timeless]

http://developer.mozilla.org/en/docs/Mercurial/Desired_Features#Allow_marking_lines_of_.22file.22_and_.22annotate.22_view

i'd integrate it, if the feature existed. 

http://hg.intevation.org/mercurial/file/default/mercurial/hgweb/hgweb_mod.py seems to be where the logic is if you want to take a crack at it.

Comment 2

[(not currently active) Ted Mielczarek]

I don't know if we're taking custom Hg patches in our installation or if we'd need to get this upstream. bsmedberg?

Comment 3

[Benjamin Smedberg]

We are not taking custom Hg patches, except for perhaps the patch for genshi templates. We will take mercurial extensions that affect hgweb, or custom templates.

Comment 4

[Dirkjan Ochtman (:djc)]

Hmm. I think we would accept this is in mainline. It should basically be a little code in webcommands.py:annotate, which gives each line tuple (I think they are tuples now) an extra element 'marked', default False, which gets set to True based on a mark param in the URL. Then it still needs some template support.

Comment 5

[Gregory Szorc [:gps]]

Please file an upstream bug to fix Mercurial's templates. If this makes it upstream, we'll deploy the fix.

http://bz.selenic.com/