Closed
Bug 447596
Opened 16 years ago
Closed 16 years ago
Changes to allow rendering of affiliate links in the "Top 5 Climbers"
Categories
(Websites Graveyard :: spreadfirefox.com, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: paul, Assigned: abuchanan)
References
()
Details
Attachments
(1 file)
5.56 KB,
patch
|
cpollett
:
review+
|
Details | Diff | Splinter Review |
Would you please review the patch which includes changes to allow rendering of affiliate links in the "Top 5 Climbers" and some notes for my own reference.
Updated•16 years ago
|
Attachment #330905 -
Flags: review?(cpollett)
Comment 1•16 years ago
|
||
Comment on attachment 330905 [details] [diff] [review] sfx_affiliates.module patch It look okay. Maybe change <br> to <br /> if we are trying for XHTML compliant rather than HTML 4.01 + $content .= "<b>Report Affiliate Spam</b><br>Report Affiliate spam by adding comments to <a href=\"/affiliatesabuse\">this post</a> , providing as much detail as possible (why do you think this is a spammer?).";
Attachment #330905 -
Flags: review?(cpollett) → review+
Updated•16 years ago
|
Priority: -- → P1
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → buchanae
Assignee | ||
Comment 2•16 years ago
|
||
patch was committed to trunk in r17370 by paul http://viewvc.svn.mozilla.org/vc?view=rev&revision=17370
Comment 3•16 years ago
|
||
When do you mark bugs that have patches landed as fixed? (Not being snarky, I genuinely want to know; do you want for it to land on staging or something?)
Assignee | ||
Comment 4•16 years ago
|
||
nah, usual is to mark fixed when they hit trunk, so it can be verfied, etc. i just forgot. thanks!
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 5•16 years ago
|
||
Thanks; verified FIXED on https://spreadfirefox.authstage.mozilla.com/affiliates/homepage
Status: RESOLVED → VERIFIED
Updated•13 years ago
|
Product: Websites → Websites Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•