447596 - Changes to allow rendering of affiliate links in the "Top 5 Climbers"

Status: VERIFIED FIXED

(Websites Graveyard :: spreadfirefox.com, defect, P1)

Description

[Paul Booker]

Attachment: sfx_affiliates.module patch

Would you please review the patch which includes changes to allow rendering of affiliate links in the "Top 5 Climbers" and some notes for my own reference.

Comment 1

[Chris Pollett]

Comment on attachment 330905 [details] [diff] [review]
sfx_affiliates.module patch

It look okay.
Maybe change <br> to <br /> if we are trying for XHTML compliant rather than HTML 4.01


+  $content .= "<b>Report Affiliate Spam</b><br>Report Affiliate spam by adding comments to <a href=\"/affiliatesabuse\">this post</a> , providing as much detail as possible (why do you think this is a spammer?).";

Comment 2

[Alex Buchanan [:abuchanan]]

patch was committed to trunk in r17370 by paul

http://viewvc.svn.mozilla.org/vc?view=rev&revision=17370

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

When do you mark bugs that have patches landed as fixed?  (Not being snarky, I genuinely want to know; do you want for it to land on staging or something?)

Comment 4

[Alex Buchanan [:abuchanan]]

nah, usual is to mark fixed when they hit trunk, so it can be verfied, etc. i just forgot.

 thanks!

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Thanks; verified FIXED on https://spreadfirefox.authstage.mozilla.com/affiliates/homepage