447702 - bug 441686 causes problems for API violators

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Brian Crowder]

C code, such as liveconnect, which erroneously consumes private headers from spidermonkey, gets confused by the use of the "inline" keyword.  Here's a patch.

Comment 1

[Brian Crowder]

The last time I tinkered with JS_INLINE, I seriously considered created a JS_FORCE_INLINE to do what this does, and a JS_INLINE to use the "inline" keyword where it's available.  Perhaps as we move more towards C++, that becomes increasingly the right thing to do, but I am unsure.

Comment 2

[Brian Crowder]

Attachment: inline => JS_INLINE

Comment 3

[Igor Bukanov]

(In reply to comment #0)
> C code, such as liveconnect, which erroneously consumes private headers from
> spidermonkey, gets confused by the use of the "inline" keyword.  Here's a
> patch.

What is exactly the confusion? static inline in C99 has the same semantics as in C++.

Comment 4

[Brian Crowder]

Here's a log from the try server:
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1216769174.1216771603.5866.gz

Comment 5

[Brian Crowder]

Comment on attachment 331016 [details] [diff] [review]
inline => JS_INLINE

This patch unfortunately causes lots of warnings about the unused functions, in my build.  I'll investigate the TryServer build problems more.

Comment 6

[Igor Bukanov]

(In reply to comment #4)
> Here's a log from the try server:
> http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1216769174.1216771603.5866.gz

This have a simple explanation: MSVC does not support C99 including the inline keyword :( . I guess the simplest solution is to use macros.

Comment 7

[Brian Crowder]

This was fixed elsewhere.