4478 - Access violation when "viewing cookies"

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[jlupa]

in file ?/network/protocol/http/mkaccess.c
in function XP_MakeRawHTMLDialog
(I have a current CVS file) but in mine, line 3915, specificly:
-->fread(readBuf, sizeof(char), fileLength, f);

f can be null generating a access violation, bringing the program down. Simple
error checking can prevent this:

f = fopen(COOKIE_FILE, "r");
if (f)
   fread(readBuf, sizeof(char), fileLength, f);
else /* Things are going to hell in a handbasket.  Dump */
{
   XP_FREE(readBuf);
   return NULL;
}

PLEASE: This is my first "bug report".  I am now trying to run mozilla's browser
as my web browser, and every time it crashes on my, I fix it. If you don't want
these kinds of bugs written up, please email me ([e-mail]), and I
will stop. If you find this kind of bug report useful, email me and I will keep
them coming. =)  Also if you have any tips about figuring out file versions,
etc, I am new to CVS and could use pointers which would make my bug reports
better.

Comment 1

[Stephen P. Morse]

I find your kind of bug reporting not only useful but a terrific time saver.
Not only do you report the bugs but you give the fixes as well.  Please don't
stop -- we need more people like you.  Thanks.

Comment 2

[Stephen P. Morse]

Made the indicated change to mkaccess.c and checked it in.

Comment 3

[Paul MacQuiddy]

since the reporter provided the fix, and morse checked it in, I will mark
verified.

Comment 4

[leger]

Changing all Networking Library/Browser bugs to Networking-Core component for
Browser.

Occasionally, Bugzilla will burp and cause Verified bugs to reopen when I do
this in a bulk change.  If this happens, I will fix. ;-)

Comment 5

[leger]

Bulk move of all Networking-Core (to be deleted component) bugs to new
Networking component.