449045 - Drop support for type="timed" for textboxes

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Dão Gottwald [:dao]]

It seems that all of our timed textboxes are search / filter fields. We should:

1. use type="search" for those textboxes,
2. maybe map type="timed" to the search binding for one major release,
3. eventually remove support for type="timed".

Comment 1

[David Ascher (:davida)]

It seems weird to assume a specific function (search) from a UI behavior.  

Are there changes in functionality implied in the switch from timed to search?  

FYI, I'm using a timed textbox in a non-search related dialog (the autoconfig dialog for account creation in thunderbird).  

I would change to "search" if I still get the timed-like behavior, but it feels odd.

(aside: MDC needs to be updated if this happens: http://developer.mozilla.org/index.php?title=En/XUL/Attribute/Textbox.type&highlight=textbox+search)

Comment 2

[Dão Gottwald [:dao]]

(In reply to comment #1)
> It seems weird to assume a specific function (search) from a UI behavior.

It's just an observation. The vast majority of timed textboxes are used for searching / filtering.
Your autoconfig dialog is in fact the first and only exception that I know of. It's a valid use case, though. I'm not sure if that justifies keeping the binding in toolkit. In such rare cases the desired behavior could be achieved easily using oninput and a custom timer. I would advise against using type="search".

Comment 3

[David Marteau]

timed is a general behavior, it has nothing to do with the specialization of the textbox (such has search).  Timed textbox are useful when associated with 'number' textbox for updating  numerical property in 'real-time'. 

Support for timed textbox could be enabled when 'timeout' attribute is specified.

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 449045 - Drop support for type="timed" textboxes.

Review commit: https://reviewboard.mozilla.org/r/210598/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210598/

Comment 6

[Neil Deakin]

Comment on attachment 8940317 [details]
Bug 449045 - Drop support for type="timed" textboxes.

https://reviewboard.mozilla.org/r/210598/#review216690

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eef0978b42ad
Drop support for type=timed textboxes. r=enn

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/eef0978b42ad