449146 - Remove dead libsec function declarations

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Julien Pierre]

I stumbled on some dead code while investigating something else. I will attach a patch to remove it.

Comment 1

[Julien Pierre]

Attachment: Remove dead code

These functions only have declarations, but no definitions, and are ifdef'ed out. There is no reason to keep them in the source.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 332288 [details] [diff] [review]
Remove dead code

Julien, this file contains a large block that is ifdef'ed out with 
#ifdef notdef.
This patch removes about 80% of the declarations in that ifdef'ed 
block.  Why not remove it all?

Comment 3

[Julien Pierre]

When I looked at it, it seemed that the other functions that I left in still exist somewhere else. But now that you point this out, it appears these declarations are not necessary. I am OK with removing the whole block.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 332288 [details] [diff] [review]
Remove dead code

Please remove the whole #ifdef notdef block. Thanks.

Comment 5

[Julien Pierre]

Thanks, Nelson. I removed the ifdef block on the trunk.

Checking in certdb/certdb.h;
/cvsroot/mozilla/security/nss/lib/certdb/certdb.h,v  <--  certdb.h
new revision: 1.21; previous revision: 1.20
done