449291 - In <TestEncoding.cpp>, multiple "warning C4309: 'initializing' : truncation of constant value"

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/2008080519 SeaMonkey/2.0a1pre] (home, optim default) (W2Ksp4)

{{
.../xpcom/tests/TestEncoding.cpp(61) : warning C4309: 'initializing' : truncation of constant value
.../xpcom/tests/TestEncoding.cpp(61) : warning C4309: 'initializing' : truncation of constant value
.../xpcom/tests/TestEncoding.cpp(61) : warning C4309: 'initializing' : truncation of constant value
.../xpcom/tests/TestEncoding.cpp(61) : warning C4309: 'initializing' : truncation of constant value
.../xpcom/tests/TestEncoding.cpp(105) : warning C4309: 'initializing' : truncation of constant value
.../xpcom/tests/TestEncoding.cpp(105) : warning C4309: 'initializing' : truncation of constant value
.../xpcom/tests/TestEncoding.cpp(105) : warning C4309: 'initializing' : truncation of constant value
.../xpcom/tests/TestEncoding.cpp(105) : warning C4309: 'initializing' : truncation of constant value
.../xpcom/tests/TestEncoding.cpp(105) : warning C4309: 'initializing' : truncation of constant value
.../xpcom/tests/TestEncoding.cpp(105) : warning C4309: 'initializing' : truncation of constant value
.../xpcom/tests/TestEncoding.cpp(148) : warning C4309: 'initializing' : truncation of constant value
.../xpcom/tests/TestEncoding.cpp(148) : warning C4309: 'initializing' : truncation of constant value
.../xpcom/tests/TestEncoding.cpp(148) : warning C4309: 'initializing' : truncation of constant value
.../xpcom/tests/TestEncoding.cpp(191) : warning C4309: 'initializing' : truncation of constant value
.../xpcom/tests/TestEncoding.cpp(191) : warning C4309: 'initializing' : truncation of constant value
.../xpcom/tests/TestEncoding.cpp(191) : warning C4309: 'initializing' : truncation of constant value
}}

Clean up the output.

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <TestEncoding.cpp>

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/2008080519 SeaMonkey/2.0a1pre] (home, optim default) (W2Ksp4)

*Remove an extra space.
*s/0x0/0x00/g
*Add casts.

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) <TestEncoding.cpp>

Av1, with bug 410708 comment 4 suggestion(s) ;-)

Comment 3

[Benjamin Smedberg]

Comment on attachment 333054 [details] [diff] [review]
(Av2) <TestEncoding.cpp>

I'm not sure I understand which changes are fixing what.

I understand why you might need '\xEF' instead of 0xEF in a char initializer, because char may be an unsigned type.

Is PRUnichar a signed type on windows (it's a typedef of wchar_t)?

I'm pretty sure (I hope!) that the change to 0x00 is not required, and I think it makes the code less readable... please prove me right.

Comment 4

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b1pre) Gecko/20080927200111 Minefield/3.1b1pre] (home, debug default) (W2Ksp4)

Not sure if the two issues are related,
but, as this is the same test, reporting it here for now:
{
Running TestEncoding
WARNING: got a low Surrogate but no high surrogate: ...\include\string\nsUTF8Utils.h, line 718
WARNING: got a high Surrogate but no low surrogate: ...\include\string\nsUTF8Utils.h, line 709
WARNING: got a low Surrogate but no high surrogate: ...\include\string\nsUTF8Utils.h, line 631
WARNING: got a High Surrogate but no low surrogate: ...\include\string\nsUTF8Utils.h, line 619
WARNING: got a low Surrogate but no high surrogate: ...\include\string\nsUTF8Utils.h, line 361
WARNING: got a High Surrogate but no low surrogate: ...\include\string\nsUTF8Utils.h, line 345
WARNING: got a high Surrogate but no low surrogate: ...\include\string\nsUTF8Utils.h, line 709
WARNING: got a High Surrogate but no low surrogate: ...\include\string\nsUTF8Utils.h, line 619
WARNING: got a High Surrogate but no low surrogate: ...\include\string\nsUTF8Utils.h, line 345
WARNING: got a low Surrogate but no high surrogate: ...\include\string\nsUTF8Utils.h, line 718
WARNING: got a low Surrogate but no high surrogate: ...\include\string\nsUTF8Utils.h, line 631
WARNING: got a low Surrogate but no high surrogate: ...\include\string\nsUTF8Utils.h, line 361
Running TestEncoding tests...
}

Comment 5

[:Cykesiopka]

Can this be resolved?

The TestEncoding.cpp warnings were fixed in Bug 552805.

The NS_WARNINGS in nsUTF8Utils.h still seem to be there however...

Comment 6

[:Cykesiopka]

sgautherie, ping...

Comment 7

[:Cykesiopka]

Since the primary issue this bug was reported against was fixed (see Comment 5), and it has been a month without any reply, I am resolving this bug for now...