449435 - spacer attribute mapping code should not depend on computed style data

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The spacer attribute mapping code currently depends on computed style data.  It's not supposed to do this; it should just depend on the markup.

I've had a reasonably simple patch to fix this sitting in my tree for ages.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch (diff -w)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 332561 [details] [diff] [review]
patch (diff -w)

>+      nsAutoString tmp(value->GetStringValue());

|tmp| could be a |const nsString&|, right?

Other than that, looks good.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Landed: http://hg.mozilla.org/mozilla-central/rev/00a9515116e5