449692 - Conditional jump or move depends on uninitialised value(s): nsDocumentEncoder::SerializeToStringRecursive

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Mats Palmgren (inactive)]

Attachment: Valgrind output

Conditional jump or move depends on uninitialised value(s): nsDocumentEncoder::SerializeToStringRecursive.

Looks like a regression from bug 293834.

STEPS TO REPRODUCE
0. Build Firefox with:
  ac_add_options --enable-jemalloc
  ac_add_options --with-valgrind
1. "firefox -g -d valgrind"
2. File->Quit

ACTUAL RESULTS
On exit:
==10580== Conditional jump or move depends on uninitialised value(s)
==10580==    at 0x18057D94: nsDocumentEncoder::SerializeToStringRecursive(nsIDOMNode*, nsAString_internal&, int) (nsDocumentEncoder.cpp:372)

http://hg.mozilla.org/mozilla-central/index.cgi/annotate/ce485b9145bf9cf354202ca0b8d1ad839f3338cc/content/base/src/nsDocumentEncoder.cpp#l372

Comment 1

[Ben Karel [eschew]]

Attachment: Initialize the variable

Strike two for me. Dead simple fix, though.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Pushed changeset 9ae2bcce0f4a.