450782 - overpan events are hard to trigger with kinetic scrolling enabled

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: skips kinetic if fireOverpan is set, also handles theover pan if url bar is showing

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 333980 [details] [diff] [review]
skips kinetic if fireOverpan is set, also handles theover pan if url bar is showing

>           mouseup: function seh_mouseup(aEvent) {
>+            var skipKinetic = false;
>             if (aEvent.button == 0 && this.deckbrowser.dragData.dragging) {
>-              this.deckbrowser.dragData.dragging = false;
>+              if (this.deckbrowser._fireOverpan) {
>+                this.deckbrowser._endPan();
>+                skipKinetic = true;
>+              } else
>+                this.deckbrowser.dragData.dragging = false;

Add { } around the "else" (if the "if" has it, the "else" should have it)

r+ with that change

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

committed changeset 77a02dfa219d

http://hg.mozilla.org/mobile-browser/index.cgi/rev/77a02dfa219d

Comment 3

[Anna (Waverley)]

Referring to the actual state of the application I can mark this as VERIFIED FIXED on:

Build Id: Mozilla/5.0 (Maemo; Linux armv7l; rv:6.0a1) Gecko/20110510
Firefox/6.0a1 Fennec/6.0a1

Device: Nokia N900 (Maemo GTK)