450895 - build bustage on AIX : macro redefinition in nsJPEGEncoder.h and nsPNGEncoder.h

Status: RESOLVED WONTFIX

(Core :: Graphics: ImageLib, defect)

Description

[Uli Link (:ul-mcamafia)]

User-Agent:       Mozilla/5.0 (X11; U; AIX 5.1; en-US; rv:1.8.1.16) Gecko/20080711 SeaMonkey/1.1.11
Build Identifier: MOZILLA_1_8_BRANCH

Build is broken in modules/libpr0n/encoders/png/nsPNGEncoder.h and
modules/libpr0n/encoders/jpeg/nsJPEGEncoder.h

defined macro cannot be redefined w/o #undef it

Reproducible: Always

Steps to Reproduce:
1. Compile with IBM VisualAge 6 on AIX

Actual Results:  
Building deps for /home/ulink/Src/mozilla/modules/libpr0n/encoders/png/nsPNGEncoder.cpp
xlC_r -o nsPNGEncoder.o -c  -DMOZILLA_INTERNAL_API -DOSTYPE=\"AIX5.1\" -DOSARCH=\"AIX\" -DBUILD_ID=0000000000  -I../../../../dist/include/xpcom -I../../../../dist/include/gfx -I../../../../dist/include/string -I../../../../dist/include/imglib2 -I../../../../dist/include/png -I../../../../dist/include/zlib -I../../../../dist/include/imgpnge -I../../../../dist/include -I../../../../dist/include/nspr    -I../../../../dist/sdk/include         -DNDEBUG -DTRIMMED -O2 -q32 -qarch=com -qalign=full -qalias=noansi -qlanglvl=stdc99 -qmaxmem=-1   -DMOZILLA_VERSION=\"1.8.1.16\" -DMOZILLA_VERSION_U=1.8.1.16 -DAIX=1 -DHAVE_SYS_INTTYPES_H=1 -DNSCAP_DISABLE_DEBUG_PTR_TYPES=1 -DD_INO=d_ino -DSTDC_HEADERS=1 -DHAVE_ST_BLKSIZE=1 -DHAVE_SIGINFO_T=1 -DHAVE_INT16_T=1 -DHAVE_INT32_T=1 -DHAVE_INT64_T=1 -DHAVE_INT64=1 -DHAVE_UINT=1 -DHAVE_UINT_T=1 -DHAVE_UINT16_T=1 -DHAVE_DIRENT_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1 -DHAVE_NL_TYPES_H=1 -DHAVE_MALLOC_H=1 -DHAVE_X11_XKBLIB_H=1 -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_STATFS_H=1 -DHAVE_LIBC_R=1 -DHAVE_LIBM=1 -DHAVE_LIBDL=1 -DHAVE_LIBC_R=1 -DFUNCPROTO=15 -DHAVE_XSHM=1 -D_REENTRANT=1 -DHAVE_RANDOM=1 -DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1 -DHAVE_SNPRINTF=1 -DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DHAVE_STAT64=1 -DHAVE_LSTAT64=1 -DHAVE_FLOCKFILE=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STRTOK_R=1 -DHAVE_RES_NINIT=1 -DHAVE_LANGINFO_CODESET=1 -DHAVE_I18N_LC_MESSAGES=1 -DMOZ_DEFAULT_TOOLKIT=\"gtk2\" -DMOZ_WIDGET_GTK2=1 -DMOZ_ENABLE_XREMOTE=1 -DMOZ_X11=1 -DMOZ_PHOENIX=1 -DMOZ_BUILD_APP=browser -DMOZ_XUL_APP=1 -DMOZ_ENABLE_CANVAS=1 -DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DMOZ_ENABLE_COREXFONTS=1 -DMOZ_ENABLE_GNOMEUI=1 -DMOZ_EXTRA_X11CONVERTERS=1 -DOJI=1 -DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1 -DACCESSIBILITY=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DMOZ_XTF=1 -DMOZ_MATHML=1 -DMOZ_SVG=1 -DMOZ_SVG_RENDERER_CAIRO=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_FEEDS=1 -DMOZ_STORAGE=1 -DMOZ_SAFE_BROWSING=1 -DMOZ_URL_CLASSIFIER=1 -DMOZ_LOGGING=1 -DMOZ_USER_DIR=\".mozilla\" -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DMOZ_MORK=1 -DMOZ_DLL_SUFFIX=\".so\" -DXP_UNIX=1 -DUNIX_ASYNC_DNS=1 -DJS_THREADSAFE=1 -DMOZ_ACCESSIBILITY_ATK=1 -DMOZILLA_1_8_BRANCH=1 -DMOZILLA_LOCALE_VERSION=\"1.8.1\" -DMOZILLA_REGION_VERSION=\"1.8.1\" -DMOZILLA_SKIN_VERSION=\"1.8\"  -D_MOZILLA_CONFIG_H_ -DMOZILLA_CLIENT /home/ulink/Src/mozilla/modules/libpr0n/encoders/png/nsPNGEncoder.cpp
"/home/ulink/Src/mozilla/modules/libpr0n/encoders/png/nsPNGEncoder.h", line 41.9: 1540-0848 (S) The macro name "NS_DECL_IMGIENCODER" is already defined with a different definition.
"../../../../dist/include/imglib2/imgIEncoder.h", line 124.9: 1540-0425 (I) "NS_DECL_IMGIENCODER" is defined on line 124 of "/home/ulink/Src/mozilla/modules/libpr0n/encoders/png/nsPNGEncoder.cpp".
gmake[5]: *** [nsPNGEncoder.o] Error 1

same compilation error with jpeg/nsJPEGEncoder.cpp

Expected Results:  
build w/o severe warnings

Comment 1

[Uli Link (:ul-mcamafia)]

Attachment: This patch #undefs the macros before they are redefined

Problem is restricted on branch MOZILLA_1_8_BRANCH

Comment 2

[Daniel Veditz [:dveditz]]

Not "blocking" the release, but we'd like to approve the patch when it's reviewed. you might also try bsmedberg as a build reviewer

Comment 3

[Uli Link (:ul-mcamafia)]

Any other reviewer possible?

Comment 4

[Uli Link (:ul-mcamafia)]

This is the last patch needed for making Firefox 2.0.0.x / Seamonkey 1.1.x compile out of the box on AIX. So it would be nice to have this safe shot into the final release of Firefox 2.0.