451066 - packages-static should be auto-generated

Status: NEW

(Firefox Build System :: General, defect)

Description

[Shawn Wilsher :sdwilsh]

We should be building packages-static automatically with data from things like EXTRA_JS_MODULES, EXTRA_COMPONENTS, etc.

Far too often developers forget to add to packages-static and nightlies don't work.

Comment 1

[Benjamin Smedberg]

If we do this, why do we need packages-static at all? Why not just make the file list from whatever shows up in dist/bin?

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> If we do this, why do we need packages-static at all? Why not just make the
> file list from whatever shows up in dist/bin?

The main use I've seen for packages-static is to bundle the xpt files up into a few files. We'd have to change that just to bundle every xpt in components/ into a single file.

There would also have to be verification that what is currently being pushed into the dist/bin directory is the same as packages-static before it gets removed (but IMHO that's a good thing).

My only concern would be that the default is for enabling tests, which would mean that all the test files would get packaged as well (it would certainly be nice to run tests against the builds we actually ship, and this wouldn't help that).

Comment 3

[Benjamin Smedberg]

For the most part I don't think we should be shipping test files into dist/bin... but there's not currently a way to run the binary-only tests unless you put them in dist/bin.

Comment 4

[Shawn Wilsher :sdwilsh]

would disabling tests for release builds accomplish that?

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #4)
> would disabling tests for release builds accomplish that?
> 
Yes, but I'd like to see release builds have the tests run against them. Look at the nightlies - we ship them, even though all the unit test boxes could be burning away with critical errors.

Comment 6

[(not currently active) Ted Mielczarek]

I would definitely like to stop putting test cruft in dist/bin. I think on Mac/Linux run-mozilla.sh should make this work, but we'd probably be broken on Windows. According to this document, however:
http://msdn.microsoft.com/en-us/library/7d83bc18(VS.80).aspx

The current directory and all the directories in PATH are both searched, so we could either run the test programs with CWD=dist/bin, or stick dist/bin into PATH for the test run.