Closed Bug 451213 Opened 16 years ago Closed 16 years ago

1 bug, many warning fixes in nsSeaMonkeyMigrator.cpp

Categories

(Firefox :: Migration, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.1a2

People

(Reporter: mrbkap, Assigned: mrbkap)

Details

Attachments

(1 file)

/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:413: warning: missing braces around initializer for ‘nsNetscapeProfileMigratorBase::PrefTransform::<anonymous union>’
nsDogbertProfileMigrator.cpp
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp: In member function ‘nsresult nsSeamonkeyProfileMigrator::CopyPasswords(PRBool)’:
/home/mrbkap/work/opt/mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp:684: warning: ‘rv’ may be used uninitialized in this function

The last warning is a real bug. The first many warnings are annoying and easy to fix.
Attached patch FixSplinter Review
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #334514 - Flags: review?(gavin.sharp)
Attachment #334514 - Flags: review?(gavin.sharp) → review+
That bug might be the cause of bug 441630, fwiw (see my comment there).
pushed to mozilla-central: http://hg.mozilla.org/mozilla-central/index.cgi/rev/3c09b73c94ed
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: