451758 - Highlight shared searches in userprefs.cgi

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Frédéric Buclin]

Attachment: screenshot

When you have a huge list of saved searches, it's hard to track those you share with others. We should add a class to them to distinguish them more easily.

In the attached screenshot, one of them is easily visible because it has an additional string appended to it ("shared with 8 users"), but the other one is almost "invisible".

While we are on it, the "shared with ..." string should be on its own line, because wrapping here is really not nice.

Comment 1

[Matt Selsky [:selsky]]

Is the extra class still necessary now that picking a group creates an "Add to footer" checkbox next to the group?  That should make it less "invisible".

Comment 2

[Frédéric Buclin]

(In reply to Matt Selsky [:selsky] from comment #1)
> Is the extra class still necessary now that picking a group creates an "Add
> to footer" checkbox next to the group?  That should make it less "invisible".

"Add to footer" is only available to power users. Normal users don't have this checkbox at all. So yes, this is still needed.

Comment 3

[Sunil Joshi [:sjoshi]]

Attachment: Patch-v1

Patch attached with the fix.

"shared with ..." string should be on its own line, this wont exist anymore.

Comment 4

[Frédéric Buclin]

Comment on attachment 771658 [details] [diff] [review]
Patch-v1

Bitrot in global.css. Trivial to fix.

Comment 5

[Sunil Joshi [:sjoshi]]

Attachment: Patch-v2

Comment 6

[:glob ✱]

Comment on attachment 811534 [details] [diff] [review]
Patch-v2

r=glob

Comment 7

[Simon Green]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified skins/standard/global.css
modified template/en/default/account/prefs/saved-searches.html.tmpl
Committed revision 8800.