451760 - Allow matching at beginning of title/url by pref

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Ed Lee :Mardak]

Firefox 3.1 already supports ways to match only urls and visited history, so the main thing missing behavior of Firefox 2 is matching only at the beginning.

We already have browser.urlbar.matchBehavior to indicate to match anywhere or match on boundaries, so it'll be easy to make it specify to match at the beginning.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

matchBehavior of 3 will only match at the beginning. Testcase tests positive and negative matches as well as a sanity check.

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 335096 [details] [diff] [review]
v1

r=me, thanks

Comment 3

[Ed Lee :Mardak]

http://hg.mozilla.org/mozilla-central/index.cgi/rev/4a054a681d76

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using the pref setting in comment 0; substrings with that pref set to "3" fail to be found, with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1b1pre) Gecko/20080911135921 Minefield/3.1b1pre

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b1pre) Gecko/20080911105329 Minefield/3.1b1pre

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b1pre) Gecko/20080911020347 Minefield/3.1b1pr

Comment 6

[Gene Emelko]

I use Win-XP Pro and Firefox 3.0.5 -- just checked for updates -- none shown
I have set the following in about:config

browser.urlbar.matchBehavior .. 3
browser.urlbar.matchOnlyTyped .. true

however, typing in just fi also brings up about:conFIig

Have I missed something?

Comment 7

[Trel]

(In reply to comment #6)
> I use Win-XP Pro and Firefox 3.0.5 -- just checked for updates -- none shown
> I have set the following in about:config
> 
> browser.urlbar.matchBehavior .. 3
> browser.urlbar.matchOnlyTyped .. true
> 
> however, typing in just fi also brings up about:conFIig
> 
> Have I missed something?


Yes, I believe this pref is in 3.1 but not 3.0
(3.1 not being a stable release yet wouldn't show up as an update to 3.0)