Closed Bug 451919 Opened 16 years ago Closed 12 years ago

Remove |APP_XPCOM_LIBS| from /calendar/sunbird/

Categories

(Calendar :: Sunbird Only, defect)

Product:
Calendar
Component:
Sunbird Only
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sgautherie, Assigned: ewong)

References

(
URL
)

Details

Attachments

(1 file)

Removed |APP_XPCOM_LIBS| from /calendar/sunbird/
598 bytes, patch
Fallen
: review+
sgautherie
: feedback+
Details | Diff | Splinter Review 
Port |Bug 451871 – Remove |MOZILLA_INTERNAL_API| from /suite/| to Calendar.
Calendar core code already is ready for frozen linkage (just compiles non-frozen on branch). Only Sunbird may need some changes.
Yeah, that's what the URL shows.
Making summary more explicit.
Summary: Remove |APP_XPCOM_LIBS| from /calendar/ → Remove |APP_XPCOM_LIBS| from /calendar/sunbird/
Adding dependency to Bug 451871. Once that bug is fixed we might port it.
Depends on: 451871
With bug #680753 pending checkin-needed,  wouldn't this bug be invalid?
Component: Build Config → Sunbird Only
QA Contact: build → sunbird
(In reply to Stefan Sitter from comment #3)
> Adding dependency to Bug 451871. Once that bug is fixed we might port it.

This bug can (now) be done without waiting for bug 451871.
Severity: normal → trivial
No longer depends on: 451871
Flags: in-testsuite-
Whiteboard: [good first bug][mentor=sgautherie]
Depends on: 680753
ToDo: simply replace the variable by its value then remove the former.
Whiteboard: [good first bug][mentor=sgautherie] → [good first bug][mentor=sgautherie][lang=make]
Assignee: nobody → ewong
Status: NEW → ASSIGNED

        Attachment #602336 -
        Flags: review?(philipp)

    
  

        Attachment #602336 -
        Flags: feedback+

        Attachment #602336 -
        Flags: review?(philipp) → review+

    
    

    
  
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/a5bedd2e41b1
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

    
  
Whiteboard: [good first bug][mentor=sgautherie][lang=make]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: