Closed Bug 452075 Opened 16 years ago Closed 16 years ago

Clean up the bookmark editor dialog

Categories

(Firefox for Android Graveyard :: Bookmarks, defect, P2)

Product:
Firefox for Android Graveyard
Component:
Bookmarks
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
fennec1.0a1

People

(Reporter: madhava, Assigned: mfinkle)

Details

(Whiteboard: UI polish)

Attachments

(1 file)

cleanup bookmark editor
4.33 KB, patch
Gavin
: review+
Details | Diff | Splinter Review 
We have only a few modal dialogs (all of them overlays) in Fennec, but they mostly don't have a clear consistent method to dismiss them.  The bookmarks and navigations (URL entry/search/awesomebar) screens are two examples of this.  The "Edit bookmark" screen has a cancel button, but it should probably take on the method used by these other dialogs, once one is in place.
Whiteboard: UI polish
Flags: blocking-fennec1.0+
Assignee: nobody → mark.finkle
Priority: -- → P2
neil, can you take a look at this?
Assignee: mark.finkle → enndeakin
mfinkle: since neil is away, can you try and get in a fix for this, at least for the awesomebar?
Assignee: enndeakin → mark.finkle
* Converts the bookmark editor panel to "instant apply"
* Removes "Done" and "Cancel" buttons (and the strings in the DTD)
* Adds a (X) style close button - just like the bookmark list panel
* Sets focus to the Name field on show
Attachment #341679 - Flags: review?(gavin.sharp)
Attachment #341679 - Flags: review?(gavin.sharp) → review+
http://hg.mozilla.org/mobile-browser/rev/1822be625a06

Let's take any other dialog fixups as separate bugs
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Summary: Need way to dismiss modal dialogs → Clean up the bookmark editor dialog
this has been rewritten 100% since this checkin...verified with beta3
Status: RESOLVED → VERIFIED
Component: General → Bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: