Closed Bug 452300 Opened 16 years ago Closed 16 years ago

update product-details file for 2.0.0.17/3.0.2 (update for new locales in fx 3.0.2 as well)

Categories

(www.mozilla.org :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: Pike, Assigned: clouserw)

Details

(Keywords: relnote)

Attachments

(1 file, 1 obsolete file)

Here's the changes we want to see for Firefox 3.0.2 in the product details php and the release notes:

The following two localizations move from beta to a real release, with all bells and whistles:

si - Sinhala
sl - Slovene

We're adding 8 new locales for 3.0.2 as Beta, that'd be 

    * Bengali (bn-IN)
    * Galician (gl)
    * Hindi (hi-IN)
    * Icelandic (is)
    * Kannada (kn)
    * Marathi (mr)
    * Telugu (te)
    * Thai (th)
Summary: Update moco website for new locales in fx 3.0.2 → update product-details file for 2.0.0.17/3.0.2 (update for new locales in fx 3.0.2 as well)
Attached patch Patch v1 (obsolete) — Splinter Review
Here's my first attempt. This assumes the scheduled release date of September 11. If that changes, we'll need to update that file for both 2.0.0.17 and 3.0.2.

Wil, does this look good?

Note that I didn't update file sizes at all since it seems all Firefox 3 file sizes in the product-details file are the same across locales. Eventually we should update them to be correct per locale, but that's not this bug.
Attachment #335791 - Flags: review?(clouserw)
Comment on attachment 335791 [details] [diff] [review]
Patch v1

Everything looks good except your beta builds don't have commas after them so it'll be a parse error.  If I'm applying this patch I can fix it when I do.
Attachment #335791 - Flags: review?(clouserw) → review-
(In reply to comment #1)
> Note that I didn't update file sizes at all since it seems all Firefox 3 file
> sizes in the product-details file are the same across locales. Eventually we
> should update them to be correct per locale, but that's not this bug.
> 

The file sizes change when needed - they should all be pretty accurate...
Attached patch Patch v2Splinter Review
Might as well have a correct patch here in the bug, just in case.
Attachment #335791 - Attachment is obsolete: true
Attachment #335794 - Flags: review?(clouserw)
Attachment #335794 - Flags: review?(clouserw) → review+
Will - can you apply this? I don't have access to that part of the SVN tree.
Assignee: nobody → clouserw
beltzner: yep, this is in r18403
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Component: www.mozilla.org/firefox → www.mozilla.org
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: