Closed Bug 452441 Opened 16 years ago Closed 16 years ago

upvar staticDepth limit missing from BindNameToSlot

Categories

(Core :: JavaScript Engine, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.1

People

(Reporter: brendan, Assigned: brendan)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Fix attached, based on tracemonkey repo.

/be
Attachment #335723 - Flags: review?(igor)
Status: NEW → ASSIGNED
Priority: -- → P1
Comment on attachment 335723 [details] [diff] [review]
patch

Sigh, this mean one more iteration with the bug 448828, but whatever.
Attachment #335723 - Flags: review?(igor) → review+
Fixed on m-c:

http://hg.mozilla.org/mozilla-central/index.cgi/rev/9ecf699d4047

/be
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Backed out at Brendan's request, to see if it fixes linux mochitest failures.
* Failing tinderbox log:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1219955155.1219959439.15309.gz#err2
* Backout:
http://hg.mozilla.org/mozilla-central/rev/fe61440b3e42
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Looks like the orange was sporadic -- the next build on that tinderbox was green, and it was using the same code as the orange build. (It started building before my backout)

So, this should be safe to re-land.
Re-landed as http://hg.mozilla.org/mozilla-central/rev/018b8ac99a4c
Status: REOPENED → RESOLVED
Closed: 16 years ago16 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: