Closed Bug 452486 Opened 16 years ago Closed 16 years ago

Create components when we actually have a profile

Categories

(Toolkit :: Startup and Profile System, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.1b1

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

xpcom-startup and app-startup happen to early, and you aren't given a profile.  Currently, anyone who needs a profile has to be created then, and then register an observer for profile-after-change.  We can simplify this by just creating them if they register with the category manager at this time.
Attached patch v1.0Splinter Review
This does the trick, but I'm not sure if it's what bsmedberg is going to want.
Attachment #335773 - Flags: review?(benjamin)
Whiteboard: [has patch][needs review bsmedberg]
Not particularly wanting notification proliferation, but I wonder if a different named notification would be better to separate out the ways you register for it?
Keywords: dev-doc-needed
Attachment #335773 - Flags: review?(benjamin) → review+
(In reply to comment #2)
> Not particularly wanting notification proliferation, but I wonder if a
> different named notification would be better to separate out the ways you
> register for it?
I'm going to assume that bsmedberg doesn't think it matters either way?
Whiteboard: [has patch][needs review bsmedberg] → [has patch][has review][can land]
I prefer to keep the names the same, actually.
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/7a679b9335f3
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review][can land]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: