Closed Bug 452677 Opened 16 years ago Closed 16 years ago

Control characters in WebSearchField are replaced with nothing, rather than a space

Categories

(Camino Graveyard :: Toolbars & Menus, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla-graveyard, Assigned: bugzilla-graveyard)

References

Details

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
Bug 391087 comment 12 notes "newlines pasted into the search field should probably become spaces". I agree. Right now they're being turned into nothing, which leads to problems when copying and pasting text there. For example, one might wish to copy "some\rtext" and search for "some text", but right now you'd get "sometext" instead.

This is a one-line change to WebSearchField.mm that requires bug 411165's NSString+Utils changes to work properly.
Comment on attachment 335955 [details] [diff] [review]
fix v1.0

This is pretty redonkulous, so requesting r/sr together.
Attachment #335955 - Flags: superreview?(mikepinkerton)
Attachment #335955 - Flags: review?(trendyhendy2000)
Attachment #335955 - Flags: superreview?(mikepinkerton) → superreview+
Comment on attachment 335955 [details] [diff] [review]
fix v1.0

sr=pink. make it so.
Attachment #335955 - Flags: review?(trendyhendy2000) → review+
Landed on cvs trunk.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: