Closed Bug 453384 Opened 16 years ago Closed 16 years ago

Change NS_HILDON by MOZ_WIDGET_GTK2_MAEMO

Categories

(Toolkit Graveyard :: Build Config, defect)

Other
Maemo
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: tonikitoo, Assigned: tonikitoo)

References

Details

(Keywords: mobile)

Attachments

(3 obsolete files)

MOZ_WIDGET_GTK_MAEMO is more descriptive and express better specific changes in mozilla' gtk2 toolkit support for maemo.
Attachment #336590 - Flags: superreview?
Attachment #336590 - Flags: review?(blassey)
Component: General → Build Config
Keywords: mobile
Product: Fennec → Toolkit
QA Contact: general → build-config
Attached patch GTK -> GTK2 (obsolete) — Splinter Review
Attachment #336590 - Attachment is obsolete: true
Attachment #336593 - Flags: superreview?
Attachment #336593 - Flags: review?(blassey)
Attachment #336590 - Flags: superreview?
Attachment #336590 - Flags: review?(blassey)
Summary: Change NS_HILDON by MOZ_WIDGET_GTK_MAEMO → Change NS_HILDON by MOZ_WIDGET_GTK2_MAEMO
i do not understand why the change.

does libhildonmime imply MOZ_WIDGET_GTK_MAEMO now?  What about osso stuff?
Attached patch v2 (obsolete) — Splinter Review
better pkg-config check (?)

doug, for NS_OSSO to NS_MAEMO I will file another bug.
Attachment #336593 - Attachment is obsolete: true
Attachment #336603 - Flags: superreview?
Attachment #336603 - Flags: review?(blassey)
Attachment #336593 - Flags: superreview?
Attachment #336593 - Flags: review?(blassey)
After a fair amount of discussion on irc, I'm going to mark this as invalid.  Hildon is more than just widget and more than just maemo, so changing the macro to MOZ_WIDGET_GTK2_MAEMO wouldn't quite be right.  

It seems the other alternative would be to create a separate macro for everything that hildon is (MOZ_WIDGET_GTK2_HILDON, MOZ_WIDGET_QT_HILDON, MOZ_MIME_HILDON, etc...), but this seems like a mess IMHO.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → INVALID
agreed
How about MOZ_PLATFORM_HILDON?

NS_HILDON, NS_MAEMO and NS_OSSO are all completely meaningless to most people reading the code.
that works for me, although there should probably be MOZ_PLATFORM_HILDON and MOZ_PLATFORM_MAEMO since there are a couple things we need to do for maemo that aren't for other hildon platforms.
That's fine. It'll be a significant help to people reading the code.
Comment on attachment 336603 [details] [diff] [review]
v2

looks like this has bitrotted quite a bit
Attachment #336603 - Attachment is obsolete: true
Attachment #336603 - Flags: superreview?
Attachment #336603 - Flags: review?(bugmail)
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: