453763 - nsIMsgFolderNotificationService needs a folderAdded notification

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

Bug 439225 revamped nsIMsgFolderNotificationService.  It was still desired to provide a folderAdded notification, which is being spun off to this bug.

STEEL uses nsIMsgFolderNotificationService for its notifications and wants (actually, currently thinks) it can get these from the (old version of the) interface.  Marking this as blocking STEEL 0.1 (bug 408370).

Comment 1

[Rain [:rain1] (inactive)]

(In reply to comment #0)
> STEEL uses nsIMsgFolderNotificationService for its notifications and wants
> (actually, currently thinks) it can get these from the (old version of the)
> interface.

Yes, that sounds right -- it didn't actually get the notifications.

I'm not assigning this to myself right now, as there are a couple of other things in my way, but I think I'll look into this if no one else gets to it first.

Comment 2

[David Ascher (:davida)]

STEEL isn't targeted for b1 at this stage, so this bug doesn't need to either. But doing it early would of course be fine.

Comment 3

[David :Bienvenu]

moving to b2

Comment 4

[David :Bienvenu]

sid0, can you take this one now?

Comment 5

[Rain [:rain1] (inactive)]

Yes.

Comment 6

[Rain [:rain1] (inactive)]

Attachment: folderAdded notification + changes to consumers + tests for local folders

The patch includes
- additions to the interfaces, including a new flag
- backend code to support this
- tests for local folders
- temporarily disable the notification for consumers -- they can re-enable it as they see fit.

I had to break up CreateSubfolder, as it was called on copy, too. This also gave me the opportunity to add an extra parameter and clean up some of the code there. Suggestions for better names?

Asking for r/sr=bienvenu, r=asuth for gloda changes (more like testing to see if this works for him ;) ) and r=Standard8 for test changes.

Comment 7

[Rain [:rain1] (inactive)]

Comment on attachment 352778 [details] [diff] [review]
folderAdded notification + changes to consumers + tests for local folders

Gah, sorry, a couple of dump statements crept in -- I've removed them locally.

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 352778 [details] [diff] [review]
folderAdded notification + changes to consumers + tests for local folders

r=me for the unit test changes.

Comment 9

[Rain [:rain1] (inactive)]

Attachment: updated patch, without the dump statements [Checkin: Comment 10]

As this has sufficient reviews to get checked in and there are a couple of patches held up because of this, I'll cancel asuth's review for the moment.

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 354226 [details] [diff] [review]
updated patch, without the dump statements
[Checkin: Comment 10]

http://hg.mozilla.org/comm-central/rev/59db95131052