Closed
Bug 453766
Opened 16 years ago
Closed 14 years ago
Checking mCopyState and copySucceeded in nsMsgLocalMailFolder::EndCopy is not needed because these values is checked at the beginning of the function.
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.3a1
People
(Reporter: hiro, Assigned: hiro)
Details
Attachments
(1 file, 1 obsolete file)
|
3.29 KB,
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.15) Gecko/20080702 Ubuntu/8.04 (hardy) Firefox/2.0.0.15 Kazehakase/0.5.4 Build Identifier: Checking mCopyState and copySucceeded in nsMsgLocalMailFolder::EndCopy is not needed because these values are checked at the beginning of the function. Reproducible: Always Steps to Reproduce: 1. 2. 3.
|
Assignee | |
Comment 1•16 years ago
|
||
The patch also changes the function argument name. copySucceeded -> aCopySucceeded
Attachment #336977 -
Flags: superreview?(bienvenu)
Attachment #336977 -
Flags: review?(bienvenu)
|
||
Updated•16 years ago
|
Component: General → Backend
Product: Thunderbird → MailNews Core
QA Contact: general → backend
|
|
||
Updated•16 years ago
|
Assignee: nobody → poincare
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Version: unspecified → Trunk
|
||
Comment 2•14 years ago
|
||
thx for the patch, I de-bitrotted it and it seems fine.
Attachment #336977 -
Attachment is obsolete: true
Attachment #483970 -
Flags: review+
Attachment #336977 -
Flags: superreview?(bienvenu)
Attachment #336977 -
Flags: review?(bienvenu)
|
|
||
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 3•14 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/e6c88bcb6d6c
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a1
You need to log in
before you can comment on or make changes to this bug.
Description
•