453979 - nsIMsgIncomingServer isSecureServer attribute obsolete

Status: RESOLVED FIXED

(MailNews Core :: Networking, defect)

Description

[David :Bienvenu]

No one uses this so it can be removed.

Comment 1

[Ben Bucksch (:BenB)]

It also does not seem to do anything.

Comment 2

[Joshua Cranmer [:jcranmer]]

I'm removing this in my work with bug 435775:
http://hg.mozilla.org/users/Pidgeot18_gmail.com/trunk_mq/file/tip/rmserver#l431

Comment 3

[:aceman]

jcranmer, dbienvenu, I could try to do this bug. But I can't do the full range of bug 435775. Would it be OK?

Comment 4

[Joshua Cranmer [:jcranmer]]

Go for it; I've not done any work on bug 435775 for a long time.

Comment 5

[:aceman]

Thanks.

Comment 6

[:aceman]

Attachment: patch

I remove the member variable.
I also remove also the GetIsSecureServer methods where found. They were not using the variable, but they do not seem to be called from anywhere either.
Should this line be removed too?
base/ispdata/aol.rdf:            <NC:isSecureServer>false</NC:isSecureServer>

Comment 7

[:aceman]

Yeah, I'll update the uuid in the next version.

Comment 8

[Ben Bucksch (:BenB)]

aceman: aol.rdf, gmail.rdf and README in ispdata/ should all be entirely removed.

Comment 9

[David :Bienvenu]

(In reply to Ben Bucksch (:BenB) from comment #8)
> aceman: aol.rdf, gmail.rdf and README in ispdata/ should all be entirely
> removed.

as long as SeaMonkey doesn't use them (I don't think it does)

Comment 10

[Ben Bucksch (:BenB)]

Yeah, up to Neil. At minimum aol.rdf and README should be removed, because there's no point to special-case AOL.

Comment 11

[David :Bienvenu]

last I checked, SeaMonkey isn't using the new autoconfig (which is irrelevant if it's not using the ispdata either)

Comment 12

[Mark Banner (:standard8)]

(In reply to David :Bienvenu from comment #11)
> last I checked, SeaMonkey isn't using the new autoconfig (which is
> irrelevant if it's not using the ispdata either)

SM (and ourselves!) use it for Movemail, but aol.rdf & gmail.rdf and the README can go away happily, xref:

http://mxr.mozilla.org/comm-central/source/mailnews/base/ispdata/Makefile.in

Comment 13

[:aceman]

Should I do it in this bug or another one?

Comment 14

[:aceman]

There seems to be bug 732106 for that.

Comment 15

[:aceman]

Attachment: patch v2, uuid change

Comment 16

[David :Bienvenu]

Comment on attachment 602053 [details] [diff] [review]
patch v2, uuid change

thx for the patch

Comment 17

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/comm-central/rev/4ce2a7788011