454130 - Deprecate the ini creation macros from common.nsh

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

These provide little value for the individual applications and at times create build warning when Firefox adds new functionality to these. I will leave these macros in common.nsh marked a deprecated until all consumers no longer use them and copy the code that Firefox uses over to its unstaller.nsi / uninstaller.nsi.

SeaMonkey should copy the appropriate macros when it is updated to use the new code as was done for Thunderbird.

Not sure if McCoy has landed its installer code... either way the macros it uses should just be copied over.

I'll take care of Firefox in this bug and mark the macros as deprecated.

I'll file a new bug for Thunderbird and take care of the changes needed for it in the new bug.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: Toolkit and Firefox patch rev1

Comment 2

[Robert Strong (they/them - no direct email)]

Filed bug 454133 for Thunderbird... it isn't dependent since there is nothing in this bug the copying of the code depends on.

Comment 3

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/c83952b7df09c4df2c0652adf4c5f2841d491b3c