454507 - Contexts menu for links in emails "Copy Link Location" and "Copy" both uses C as accesskey

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[Daniel Holbert [:dholbert]]

One of the changes between Firefox 2 and Firefox 3 was that the hotkey for  "Copy Link Location" changed from "c" to "a".  However, in Thunderbird, it's still "c".  Thunderbird should change to match Firefox.

Steps to reproduce:
 1. View an email that includes a hyperlink
 2. Right-click the hyperlink
 3. Press 'a'

EXPECTED RESULTS:
"Copy Link Location" should be chosen

ACTUAL RESULTS:
"Select All" is chosen

Note: In Firefox 3, 'Select All' doesn't even appear in hyperlink context menus *at all*, which removes the ambiguity.  It does appear in non-hyperlink context menus, though, and 'a' maps to Select All in those menus.

Tested using Shredder version 3.0a2 (2008072418) on Ubuntu Linux 8.10a5

Comment 1

[Scott Ritchie]

This is still true, and still relevant -- I actually use this feature in Firefox, and it annoys me slightly in Thunderbird.

Comment 2

[Jim Porter (:squib)]

We should definitely do this, since Copy and Copy Link Location are using the same access key. To see this in action, select some text (any text) and then right-click on a link.

Comment 3

[Magnus Melin [:mkmelin]]

"a" is already used for "Select All". L seems to be free though

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Comment 5

[Jim Porter (:squib)]

Comment on attachment 667147 [details] [diff] [review]
proposed fix

rs=me. Sorry about the delay!

Comment 6

[Magnus Melin [:mkmelin]]

http://hg.mozilla.org/comm-central/rev/303a9adae549 -> FIXED