454654 - Fix text attributes tests so they work on all platforms

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

On Windows, the pixel size and font family strings are different.

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Patch

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 337936 [details] [diff] [review]
Patch

r=me but please consider another approach, it is getting font size and family from document element  for example

Comment 3

[Marco Zehe (:MarcoZ)]

Attachment: Use getComputedStyle instead.

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 338050 [details] [diff] [review]
Use getComputedStyle instead.

r=me but please consider to use computedStyles for all styes and all defAttrs entries.

I think we can use computedStyles because we don't want to test styles computing here but we want to test here logic of text attributes, right?

Following this we should consider to use computed styles for defAttrs and attrs entries both.

You can keep this in mind or file following up bug or fix this here. It's up to you.

Comment 5

[Marco Zehe (:MarcoZ)]

Pushed in changeset:
http://hg.mozilla.org/mozilla-central/rev/90fcd51e53c8