Closed Bug 455188 Opened 16 years ago Closed 16 years ago

Need to be able to pan fully while zoomed in

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Product:
Firefox for Android Graveyard
Component:
Panning/Zooming
Platform:
x86
Windows Vista
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
fennec1.0a1

People

(Reporter: pavlov, Assigned: Gavin)

Details

Attachments

(2 files)

patch
10.44 KB, patch
Details | Diff | Splinter Review
startKinetic uses helper functions
13.41 KB, patch
pavlov
: review+
Details | Diff | Splinter Review 
_constrainPanCoords doesn't currently take in to account the zoom factor which means we overly constrain how far we can pan, which makes panning while zoomed quite painful.
Flags: blocking-fennec1.0+
Target Milestone: --- → Fennec A1
Attached patch patch — — Splinter Review 
This makes sure we only pass page coords to constrainPanCoords, and includes some other simplifications. Kinetic is really broken with this, though, since it compares dragX/Y and pageX/Y which are screen coordinates and content (page) coordinates, respectively. I tried figuring out what the kinetic code is trying to do, but I didn't end up getting anywhere - I've just disabled it for now.
Attachment #338742 - Flags: review+
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
verified with beta3
Status: RESOLVED → VERIFIED
Component: General → Panning/Zooming
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: