Closed Bug 455222 Opened 16 years ago Closed 16 years ago

All XUL <script>s must have type="application/javascript"

Categories

(SeaMonkey :: General, defect)

Product:
SeaMonkey
Component:
General
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.0a1

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Ex x-
13.04 KB, patch
iannbugzilla
: review+
mkmelin
: review+
Details | Diff | Splinter Review 
... otherwise you can't use the latest JavaScript features.

For example, the Search Messages dialog can't open a message folder because the function is in a file that uses the "let" keyword, so marking as a regression.
Flags: blocking-seamonkey2.0a1?
Attached patch Proposed patch (obsolete) — — Splinter Review 
I omitted preftree.xul because that's dying.

I think some of these files are shared with Thunderbird so asking for 2 reviews.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #338528 - Flags: review?(mkmelin+mozilla)
Attachment #338528 - Flags: review?(iann_bugzilla)
Shouldn't that be application/javascript, as per bug 381467?
Er, I was specifically told (can't recall by who offhand) that application/javascript was the same as application/x-javascript, but that the latter should be considered depreciated...
OK, application/javascript it is.
Summary: All XUL <script>s must have type="application/x-javascript" → All XUL <script>s must have type="application/javascript"
Attached patch Ex x- — — Splinter Review 
I changed any existing types in those files too.
Attachment #338528 - Attachment is obsolete: true
Attachment #338530 - Flags: review?(mkmelin+mozilla)
Attachment #338530 - Flags: review?(iann_bugzilla)
Attachment #338528 - Flags: review?(mkmelin+mozilla)
Attachment #338528 - Flags: review?(iann_bugzilla)
So, does application/javascript not let you use the latest features?  If so, we should get a bug on that :/
Blocks: 381467
Either of the two types works, but omitting the type does not. Should it?
I don't think it should work with omitting the type (what about python scripts?)
Attachment #338530 - Flags: review?(mkmelin+mozilla) → review+
I'm told the search messages dialog can't open the message folder due to this bug, so blocking+ sounds reasonable.
Flags: blocking-seamonkey2.0a1? → blocking-seamonkey2.0a1+
Attachment #338530 - Flags: review?(iann_bugzilla) → review+
Pushed changeset c1f31d315bfa to mozilla-central.

Marking FIXED as this was only about untyped scripts.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
(In reply to comment #11)
> Pushed changeset c1f31d315bfa to mozilla-central.

You surely mean comm-central: http://hg.mozilla.org/comm-central/rev/c1f31d315bfa ;-)
Target Milestone: --- → seamonkey2.0alpha
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: