456458 - JS Tracer uses file-system stat structure name - WinCE compile fails

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[John Wolfe (:wolfe)]

Attachment: Renaming of structure from stat to jstracer_stat in jstracer.cpp

Need to change a local statistics structure name from stat to something else (like jstracer_stat) to avoid a compiler error due to already-defined stat structure in WinCE shunt library.

No real change to code, just a change to the name of a structure only used within the jstracer.cpp file

Comment 1

[Brian Crowder]

Comment on attachment 339859 [details] [diff] [review]
Renaming of structure from stat to jstracer_stat in jstracer.cpp

I suspect this is a bit out-of-date, are you sure it still applies and builds cleanly?  (in debug and release?)

Comment 2

[Doug Turner (:dougt)]

the patch works for me on windows ce opt.

Comment 3

[Doug Turner (:dougt)]

yeah, there are a few more in this file that need to be hit.

Comment 4

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 5

[Brian Crowder]

Comment on attachment 339965 [details] [diff] [review]
patch v.1

For brevity's sake, let's call this "jitstats" instead of "jstracer_stat".  Otherwise, looks good.

Comment 6

[Doug Turner (:dougt)]

checked in on Tue Sep 23 21:10:58 2008 -0700

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

winmo builds are building just fine.