456489 - WinCE Compiler keyword interface used in mozStorageRow.cpp

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[John Wolfe (:wolfe)]

Attachment: Change the local variable 'interface' to 'interface_iid'

Need to use a different local variable name than "interface" - which causes the Microsoft compiler to produce errors.

Comment 1

[Shawn Wilsher :sdwilsh]

Comment on attachment 339887 [details] [diff] [review]
Change the local variable 'interface' to 'interface_iid'

r=sdwilsh as long as you change the variable name to either interfaceIID or just iid.

Comment 2

[John Wolfe (:wolfe)]

Attachment: Change the local variable 'interface' to 'interfaceIID'

Change the local variable 'interface' to 'interfaceIID', as per Shawn's request

Otherwise, the patch is the same as previously.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

This bug is a slippery slope! Please, let's fix this a different way (or try to)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

"interface" is a compiler define, not a keyword. Let's just try to #undef it in the IDL.

Comment 5

[Shawn Wilsher :sdwilsh]

Comment on attachment 339901 [details] [diff] [review]
Change the local variable 'interface' to 'interfaceIID'

For future reference, if someone says r=them with comments, you don't have to ask for review again.

r=sdwilsh

(In reply to comment #4)
> "interface" is a compiler define, not a keyword. Let's just try to #undef it in
> the IDL.
It's OK since the new name is more accurate anyway.

Comment 6

[Doug Turner (:dougt)]

checked in on Tue Sep 23 21:10:58 2008 -0700