Open
Bug 456603
Opened 16 years ago
Updated 2 years ago
get rid of Windows stat cache
Categories
(Core :: XPCOM, defect)
Tracking
()
REOPENED
People
(Reporter: jaas, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
10.25 KB,
patch
|
smichaud
:
review+
dougt
:
superreview+
|
Details | Diff | Splinter Review |
701 bytes,
text/plain
|
Details |
This is the Windows part of bug 307815, we don't have to remove stat caches for all platforms at the same time. Our current stat caches are fundamentally flawed, we should remove them.
Basic try server run shows no significant perf impact, we'll see better numbers when this lands on trunk.
Attachment #340064 -
Flags: review?(doug.turner)
Updated•16 years ago
|
Attachment #340064 -
Flags: review?(doug.turner) → review+
Attachment #340064 -
Flags: superreview?(doug.turner)
Comment 2•16 years ago
|
||
Comment on attachment 340064 [details] [diff] [review] fix v1.0 drop the braces for one liners. if (aFileSize != -1 && SetEndOfFile(hFile)) { - MakeDirty(); rv = NS_OK; } assuming that this does not cause any performance regression as mentioned in bug 307815, this is fine.
Attachment #340064 -
Flags: superreview?(doug.turner) → superreview+
landed on trunk
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
backed out because of tbox issues, not necessarily anything wrong with the patch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 5•16 years ago
|
||
This might have caused a performance regression on Tp on Vista (some 30% increase). It is confusing though since the first talos runs also supposedly included the backout, but Tp consistently went up on all 4 Vista talos machines then back down again one cycle later. This was the only patch liable to have impacted, but not sure what is going on. Might be good to land in a quiet tree next time.
this is a text file containing the unit test errors that came up
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•