Closed
Bug 456679
Opened 16 years ago
Closed 16 years ago
remove category breadcrumb from mozgn.css and mozad.css
Categories
(support.mozilla.org :: General, defect)
support.mozilla.org
General
Tracking
(Not tracked)
VERIFIED
FIXED
0.8.1
People
(Reporter: cilias, Assigned: paulc)
Details
(Whiteboard: sumo_only theme)
Attachments
(1 file)
Pages using the mozgn.css stylesheet or the mozad.css stylesheet should not have the category in the breadcrumbs. Good: Firefox Support / Ask a question Bad: Firefox Support / Administration / Ask a question
Comment 1•16 years ago
|
||
I know that good old Brian struggled a bit with the breadcrumbs. Brian, do you have any insights to share here?
Updated•16 years ago
|
Assignee: nobody → paul.craciunoiu
Target Milestone: --- → 0.8
Assignee | ||
Comment 2•16 years ago
|
||
SQL query fix. Removes the "Administration" category assigned to the "Ask a question" page.
Attachment #348854 -
Flags: review?(laura)
Assignee | ||
Comment 3•16 years ago
|
||
Are there other examples of this aside from "Ask a question"?
Comment 4•16 years ago
|
||
Another example: http://support.mozilla.com/en-US/kb/SFD4
Comment 5•16 years ago
|
||
Comment on attachment 348854 [details]
SQL query
I think this has a lot more side effects than you'd like.
Attachment #348854 -
Flags: review?(laura) → review+
Updated•16 years ago
|
Attachment #348854 -
Flags: review+ → review-
Comment 6•16 years ago
|
||
Paul, maybe get Nelson to look at this query?
Assignee | ||
Comment 7•16 years ago
|
||
Nelson: could you take a look at the attached query? We could add a "LIMIT 1" just in case. I tested it locally and it worked.
Updated•16 years ago
|
Target Milestone: 0.8 → 0.9
Assignee | ||
Updated•16 years ago
|
Attachment #348854 -
Flags: review?(nelson)
Comment 8•16 years ago
|
||
Comment on attachment 348854 [details]
SQL query
I think a sql query is the wrong approach because it is not about just the "Ask a question" page (which should be decategorizable via the admin panel without a query btw), but about all pages using mozad.css and mozgn.css.
Should instead: in the breadcrumb generating code, test for $prefs['style'] == "mozad.css" || $prefs['style'] == "mozgn.css"
Attachment #348854 -
Flags: review?(nelson) → review-
Assignee | ||
Comment 9•16 years ago
|
||
r21355 (trunk) and r21356 (prod) Added a $hide_category variable to header.tpl when the tiki.tpl in mozad/ and mozgn/ is used, which should be also when mozgn.css and mozad.css are included.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•16 years ago
|
Target Milestone: 0.9 → 0.8.1
Verified FIXED on http://support-stage.mozilla.org/en-US/kb/SFD4 and http://support-stage.mozilla.org/en-US/kb/Ask+a+question.
Status: RESOLVED → VERIFIED
Updated•15 years ago
|
Whiteboard: sumo_only theme
You need to log in
before you can comment on or make changes to this bug.
Description
•