457099 - empty messages 1970 year in date when using deleteMessages with deleteStorage false

Status: NEW

(MailNews Core :: Database, defect)

Description

[Eyal Rozenberg]

My removedupes extension does:

      sourceFolder.deleteMessages(
        removalMessageHdrs, 
        msgWindow,
        true, // delete permanently
        false, // delete storage - what does this mean? 
        null, // no listener
        true // allow undo... will this be possible at all?
        );

perhaps I need to 'delete storage', but even if I don't - why do I see a bunch of dummy empty messages after deletion?

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

The argument you have labeled as delete storage is (currently, it might have changed?) "isMove".  The semantics are apparently that if the deletion is part of the move process (copy to the new folder, delete the originals), you should pass true for isMove.

Do you still get empty message headers / is this still an issue?

Comment 2

[Wayne Mery (:wsmwk)]

(In reply to Andrew Sutherland (:asuth) from comment #1)
> The argument you have labeled as delete storage is (currently, it might have
> changed?) "isMove".  The semantics are apparently that if the deletion is
> part of the move process (copy to the new folder, delete the originals), you
> should pass true for isMove.
> 
> Do you still get empty message headers / is this still an issue?

Comment 3

[Eyal Rozenberg]

Not recently, but I haven't really done mass dupe removals lately.

Comment 4

[Wayne Mery (:wsmwk)]

(In reply to Eyal Rozenberg from comment #3)
> Not recently, but I haven't really done mass dupe removals lately.

When this happened, did the empty messages show up with the proverbial 1969 or 1970 year in the date?

Comment 5

[Eyal Rozenberg]

Indeed. 1970.

Comment 6

[Jorg K (CEST = GMT+2)]

(In reply to Eyal Rozenberg from comment #0)
> false, // delete storage - what does this mean? 

FYI, this is described and implemented here:
https://dxr.mozilla.org/comm-central/source/mailnews/base/public/nsIMsgFolder.idl#393

Local folders:
https://dxr.mozilla.org/comm-central/source/mailnews/local/src/nsLocalMailFolder.cpp#1163

IMAP folders:
https://dxr.mozilla.org/comm-central/source/mailnews/imap/src/nsImapMailFolder.cpp#2190