Closed
Bug 457102
Opened 16 years ago
Closed 13 years ago
kill nsIXPointer
Categories
(Core :: DOM: Core & HTML, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: taras.mozilla, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
42.56 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
My dead method finder, showed nsXPath1SchemeProcessor::Evaluate not being used smaug suggested that I kill nsIXPointer. Question is: how much should be nuked, the entire IDL?
Reporter | ||
Updated•16 years ago
|
Blocks: static_analyses
The more the merrier :) So yes, the full IDL and anything that implements or calls it.
Comment 2•16 years ago
|
||
There is http://mxr.mozilla.org/mozilla-central/source/dom/public/idl/core/nsIDOMXMLDocument.idl#75 , though even that throws Error: uncaught exception: [Exception... "Component returned failure code: 0x80040154 (NS_ERROR_FACTORY_NOT_REGISTERED)" nsresult: "0x80040154 (NS_ERROR_FACTORY_NOT_REGISTERED)" location: "JS frame :: javascript:document.implementation.createDocument("",%20"",%20null).evaluateXPointer(""); :: <TOP_LEVEL> :: line 1" data: no] by default.
Reporter | ||
Updated•16 years ago
|
No longer blocks: static_analyses
Updated•16 years ago
|
QA Contact: content
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #507348 -
Flags: review?(jonas)
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → bzbarsky
Priority: -- → P2
Whiteboard: [need review]
Attachment #507348 -
Flags: review?(jonas) → review+
Assignee | ||
Updated•13 years ago
|
Whiteboard: [need review] → [need gk2 ship]
"[need gk2 ship]" - Does that mean "depends on bug 610267"?
Assignee | ||
Comment 5•13 years ago
|
||
I have no idea. My impression is that bug was tracking "big landings". "[need gk2 ship]" just means I need to land this but don't need to worry about it until after the tree reopens.
Assignee | ||
Comment 6•13 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/510de9fad2a9
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [need gk2 ship]
Target Milestone: --- → mozilla2.2
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•