Closed
Bug 457226
Opened 16 years ago
Closed 13 years ago
mochitest for ARIA states
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: surkov, Assigned: MarcoZ)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
3.18 KB,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
initally assigning to me, Marco feel free to take this.
Assignee | ||
Comment 1•16 years ago
|
||
Note to whoever ends up taking this: - Check that checked/unchecked are not present at the same time similar to the other tests in common.js after bug 457219 lands.
Comment 2•15 years ago
|
||
We don't have an unchecked state. We do have checks for combinations of checked+mixed. There are some aria states currently tested in test_aria_token_attrs.html and test_states.html. Do we want to do more with this bug? Maybe we should make sure all possible aria states are hit in test_states.html?
Assignee | ||
Comment 3•15 years ago
|
||
Yes, that would be the place to go.
Reporter | ||
Comment 4•15 years ago
|
||
(In reply to comment #2) > Do we want to do more with this bug? Maybe we should make sure all possible > aria states are hit in test_states.html? yes, iirc that's reason I filed this bug. reassigning to default assigne I don't think I will be really soon here.
Assignee: surkov.alexander → nobody
Comment 5•13 years ago
|
||
It's been a year and a half, and we know have states/test_aria.html is that aenough state checking for aria? If not what do we still need to test?
Reporter | ||
Comment 6•13 years ago
|
||
(In reply to comment #5) > If not what do we still need to test? somebody should run through nsARIAMap.cpp and add missed states to test_aria.html
Blocks: a11ytestdev
Updated•13 years ago
|
Assignee: nobody → marco.zehe
Assignee | ||
Comment 7•13 years ago
|
||
Attachment #579994 -
Flags: review?(surkov.alexander)
Reporter | ||
Comment 8•13 years ago
|
||
Comment on attachment 579994 [details] [diff] [review] Missing test cases >+ // aria-selectable >+ testStates("aria_selectable_listitem", STATE_SELECTABLE | STATE_SELECTED); >+ >+ // some artifact is readonly state test for aria-readonly missed?
Attachment #579994 -
Flags: review?(surkov.alexander) → review+
Assignee | ||
Comment 9•13 years ago
|
||
(In reply to alexander :surkov from comment #8) > Comment on attachment 579994 [details] [diff] [review] > Missing test cases > > > >+ // aria-selectable > >+ testStates("aria_selectable_listitem", STATE_SELECTABLE | STATE_SELECTED); > >+ > >+ // > > some artifact OK, will remove before checkin. > is readonly state test for aria-readonly missed? I saw it tested in another part of the file, so didn't put one here.
Reporter | ||
Comment 10•13 years ago
|
||
(In reply to Marco Zehe (:MarcoZ) from comment #9) > > is readonly state test for aria-readonly missed? > I saw it tested in another part of the file, so didn't put one here. of this file? It has aria-readonly occasionally, not sure on what propose but I don't see we test READONLY state.
Assignee | ||
Comment 11•13 years ago
|
||
Landed on inbound with comments addressed: http://hg.mozilla.org/integration/mozilla-inbound/rev/8a49a1709b30
Comment 12•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8a49a1709b30
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in
before you can comment on or make changes to this bug.
Description
•