Closed Bug 457313 Opened 16 years ago Closed 16 years ago

nuke dead nsGlobalWindow::ConvertCharset

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
Other
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: taras.mozilla, Assigned: taras.mozilla)

References

Details

Attachments

(1 file, 2 obsolete files)

removed include
2.92 KB, patch
Details | Diff | Splinter Review
Attached patch nuke convertcharset (obsolete) — — Splinter Review 
      No description provided.
Attachment #340641 - Flags: review?(bzbarsky)
Attachment #340641 - Flags: review?(bzbarsky) → review+
Comment on attachment 340641 [details] [diff] [review]
nuke convertcharset

Nice catch.  Can we nuke the nsICharsetConverterManager include as well?
Attachment #340641 - Flags: superreview+
pushed 41bb2af34a9b
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
backed out for now
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
So how come this got backed out?
i took out the include and that broke the build. It'll push it tomorrow.
Attached patch removed include (obsolete) — — Splinter Review 
Fixed patch, ready for checkin
Attachment #340641 - Attachment is obsolete: true
this is what i meant to upload
Attachment #341499 - Attachment is obsolete: true
pushed http://hg.mozilla.org/mozilla-central/rev/edadac8d8a50
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Assignee: nobody → tglek
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: