Closed Bug 457686 Opened 16 years ago Closed 16 years ago

appendURINode should not append to a dynamic container if we are inside an excludeItems query

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3.1b2

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file)

appendURINode should not append uri nodes when we are child of an excludeItems parent or nephew of an excludeItems root.
Attached patch patchSplinter Review
with unit test

checkin after bug 457681 since this is from a mercurial queue
Attachment #340921 - Flags: review?(dietrich)
Comment on attachment 340921 [details] [diff] [review]
patch

r=me, thanks
Attachment #340921 - Flags: review?(dietrich) → review+
http://hg.mozilla.org/mozilla-central/rev/2abc97abeabe
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b2
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: