457698 - nsNavHistoryFolderResultNode::OnItemAdded ignores dynamic containers

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak]]

nsNavHistoryFolderResultNode::OnItemAdded does not check for TYPE_DYNAMIC_CONTAINER, so when calling node->mBookmarkIndex = aIndex; we badly crash

Comment 1

[Marco Bonardo [:mak]]

raise to critical due to crash

Comment 2

[Marco Bonardo [:mak]]

Attachment: patch

with unit crashtest

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 340926 [details] [diff] [review]
patch

r=me

Comment 4

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/a031f60917f2

Comment 5

[Tracy Walker [:tracy]]

verified: assumes unit test is not crashing

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv