457810 - Speculatively load stylesheets from preloading

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

This is similar to bug 457809 but for stylesheets.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Assuming you have the nsIDocument involved in |doc|, the URI of the sheet in |uri| and an nsICSSLoaderObserver implementation (probably one which just does "return NS_OK;" as the body of StyleSheetLoaded) in |obs|:

  doc->CSSLoader()->LoadSheet(uri, doc->NodePrincipal(), obs);

will do the trick, since CSSLoader already caches loaded sheets and already coalesces sheet loads.

You probably want to avoid doing this for alternate stylesheets, though, since currently we deprioritize them and forcing them to load earlier could actually slow sites that use them down.

Comment 2

[Bjarne (:bjarne)]

See patch for bug #457809

Comment 3

[Bjarne (:bjarne)]

Attachment: V1.0 part of patch to preload stylesheets

This is the part of patch from bug #457809 needed to preload stylesheets. See bug #457809 comment #45.

Requesting another round of reviews just in case...

Comment 4

[Bjarne (:bjarne)]

Attachment: V2.0 not depending on patch from bug #457809

This can be applied without the fix for bug #457809. Not tested beyond mochitests and some random browsing since it's a trivial code-shuffle.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/bf5cf25cdd3c with the following changes to the patch:

1) No changes to nsIDocument IID
2) Fixed checkin comment.

Unfortunately, I missed the fact that the patch doesn't have the right user set.  :(

Comment 6

[Bjarne (:bjarne)]

Must have shuffled code a little too fast this morning... :\ thanks for fixing up. :)

(Apparently hg qfold does not preserve user-info. Must remember to check this next time!)

Comment 7

[Boris Zbarsky [:bzbarsky]]

Tp is looking good, on both Linux and Mac!

Comment 8

[Boris Zbarsky [:bzbarsky]]

We should probably fix bug 485012 before landing this on branch.

Comment 9

[Bjarne (:bjarne)]

Attachment: V2.0 for 1.9.1 branch

Identical to V2.0 but with issues from comment #5 fixed.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 372430 [details] [diff] [review]
V2.0 for 1.9.1 branch 

a191=beltzner

Comment 11

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/88bf56a8362c

Comment 12

[Boris Zbarsky [:bzbarsky]]

And pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e36f8c547a96 to fix the resulting test bustage due to the test fix from bug 457809 never making it to branch....