Closed
Bug 457849
Opened 16 years ago
Closed 16 years ago
DOMi fails to load main application when -inspector flag is used
Categories
(Other Applications :: DOM Inspector, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mfinkle, Assigned: mfinkle)
References
Details
Attachments
(1 file)
685 bytes,
patch
|
sdwilsh
:
review+
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
I use use DOMi to debug xul applications by passing the -inspector flag on the commandline when starting the app. This fails to load the actual application window because DOMi's commandline handler prevents the default action: http://hg.mozilla.org/dom-inspector/file/2bae5150d746/base/js/inspector-cmdline.js#l103 This was introduced in bug 340233. Simply removing the line of code allows DOMi and the application to load.
Assignee | ||
Comment 1•16 years ago
|
||
This patch simply removes the code to prevent the default command line action
Assignee: nobody → mark.finkle
Attachment #341268 -
Flags: review?(sdwilsh)
Updated•16 years ago
|
Attachment #341268 -
Flags: superreview?(neil)
Attachment #341268 -
Flags: review?(sdwilsh)
Attachment #341268 -
Flags: review?(neil)
Attachment #341268 -
Flags: review+
Comment 2•16 years ago
|
||
Comment on attachment 341268 [details] [diff] [review] patch r=sdwilsh Neil added this, so he should certainly take a look at this too.
Updated•16 years ago
|
Attachment #341268 -
Flags: superreview?(neil)
Attachment #341268 -
Flags: superreview+
Attachment #341268 -
Flags: review?(neil)
Attachment #341268 -
Flags: review+
Assignee | ||
Comment 3•16 years ago
|
||
http://hg.mozilla.org/dom-inspector/rev/033072f5b21d
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 4•16 years ago
|
||
How about something like <http://mxr.mozilla.org/mozilla-central/source/toolkit/components/console/jsconsole-clhandler.js#63> if (cmdLine.state == Ci.nsICommandLine.STATE_REMOTE_AUTO) cmdLine.preventDefault = true; FYI: The error console command line handler checks for an existing window and focuses on it if found.
You need to log in
before you can comment on or make changes to this bug.
Description
•