458057 - compile error for widget/src/gtk2/nsWindow.cpp

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Uli Link (:ul-mcamafia)]

User-Agent:       Mozilla/5.0 (X11; U; AIX 5.1; en-US; rv:1.8.1.17) Gecko/20080905 Firefox/2.0.0.17
Build Identifier: CVS HEAD + TRUNK

Compiling on a UNIX platform with non XFree86 X-server fails because 
#include <X11/XF86keysym.h> cannot be found and there are no XF86_XP keysymbols  defined on those platforms.
Found on both Firefox 3.0.3 and Trunk

Reproducible: Always

Steps to Reproduce:
1. Build on AIX 5.1 with GTK 2.10.3
2.
3.
Actual Results:  
compile error

Expected Results:  
successful compilation

Comment 1

[Uli Link (:ul-mcamafia)]

It's easy to #ifdef around, but the proper way seems using the configure's output if XFree86/X.org X server is detected instead of
 
#if not defined (_AIX41)
...
#endif /* (_AIX41) */

around the XF86_XP... keysymbols.

Comment 2

[Shailen]

In my build machine, I copied the file X11/XF86keysym.h from AIX 6 to AIX 5 under /usr/include/X11

Comment 3

[Uli Link (:ul-mcamafia)]

Attachment: For AIX compatibilty

Comment 4

[Uli Link (:ul-mcamafia)]

Usually it's not a good idea to just copy headers from newer releases back to older.

This may result in linker errors, if the new header declares something not available in the host libs, or even worse occur at runtime.

I'm not happy with the above patch because the second hunk should be included if the machine has XFree86 not vice versa.
Else it works and is a safe shot.

Comment 5

[Uli Link (:ul-mcamafia)]

(In reply to comment #2)
> In my build machine, I copied the file X11/XF86keysym.h from AIX 6 to AIX 5
> under /usr/include/X11
Missing in source diff file Firefox.base.3_0_7.source.diffs as this isn't delivered neither with AIX nor compiler

Comment 6

[Uli Link (:ul-mcamafia)]

Attachment: recreated patch with hg for trunk [Checkin: Comment 10]

Comment 7

[Uli Link (:ul-mcamafia)]

Attachment: recreated patch with hg for branch 1.9.2, context adjusted only [Checkin: Comment 13]

Comment 8

[Uli Link (:ul-mcamafia)]

Attachment: recreated patch with hg for branch 1.9.1, context adjusted only [Checkin: Comment 14]

Comment 9

[Uli Link (:ul-mcamafia)]

Another superreviewer for gfx available ???

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/9e4a10b4469e

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This is essentially NPOTB for supported platforms, so these should be easy approvals.

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 428492 [details] [diff] [review]
recreated patch with hg for branch 1.9.1, context adjusted only
[Checkin: Comment 14]

Approved for 1.9.2.3 and 1.9.1.10, a=dveditz for release-drivers

Comment 13

[Serge Gautherie (:sgautherie)]

Comment on attachment 428486 [details] [diff] [review]
recreated patch with hg for branch 1.9.2, context adjusted only
[Checkin: Comment 13]


http://hg.mozilla.org/releases/mozilla-1.9.2/rev/1ea19a395253

Comment 14

[Serge Gautherie (:sgautherie)]

Comment on attachment 428492 [details] [diff] [review]
recreated patch with hg for branch 1.9.1, context adjusted only
[Checkin: Comment 14]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/666bfd96c47f